Cloud-CV / evalai-cli

:cloud: :rocket: Official EvalAI Command Line Tool
https://cli.eval.ai
BSD 3-Clause "New" or "Revised" License
55 stars 63 forks source link

Stop displaying past challenges to participants. #39

Closed guyandtheworld closed 6 years ago

guyandtheworld commented 6 years ago

Fixes #35

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 215


Totals Coverage Status
Change from base Build 199: 0.03%
Covered Lines: 278
Relevant Lines: 307

💛 - Coveralls
RishabhJain2018 commented 6 years ago

@isht3 I think you should also check that if the challenge is approved_by_admin and publically_available then only it should appear in this list, otherwise it will create discrepancy in the data on UI and in cli. Think of a case where a host hosts a challenge and a participant participates in it but due to some reasons he has to disable the challenge then the challenge won't be available on UI but it comes on cli. Do you see what I mean here? Feel free to ask doubts if you have any.

guyandtheworld commented 6 years ago

@RishabhJain2018 Yup understood

guyandtheworld commented 6 years ago

@RishabhJain2018 I've made the changes to incorporate that, can you check?

RishabhJain2018 commented 6 years ago

@isht3 any update on this?

guyandtheworld commented 6 years ago

@RishabhJain2018 Updated with test cases.

guyandtheworld commented 6 years ago

@RishabhJain2018 Changed!

RishabhJain2018 commented 6 years ago

@isht3 One merge conflict :P

varunagrawal commented 6 years ago

Rebase! and LGTM.

guyandtheworld commented 6 years ago

@RishabhJain2018 @varunagrawal Done!