Closed guyandtheworld closed 6 years ago
Totals | |
---|---|
Change from base Build 199: | 0.03% |
Covered Lines: | 278 |
Relevant Lines: | 307 |
@isht3 I think you should also check that if the challenge is approved_by_admin
and publically_available
then only it should appear in this list, otherwise it will create discrepancy in the data on UI and in cli.
Think of a case where a host hosts a challenge and a participant participates in it but due to some reasons he has to disable the challenge then the challenge won't be available on UI but it comes on cli. Do you see what I mean here? Feel free to ask doubts if you have any.
@RishabhJain2018 Yup understood
@RishabhJain2018 I've made the changes to incorporate that, can you check?
@isht3 any update on this?
@RishabhJain2018 Updated with test cases.
@RishabhJain2018 Changed!
@isht3 One merge conflict :P
Rebase! and LGTM.
@RishabhJain2018 @varunagrawal Done!
Fixes #35