search

Cloud-CV / evalai-cli

:cloud: :rocket: Official EvalAI Command Line Tool
https://cli.eval.ai
BSD 3-Clause "New" or "Revised" License
55 stars 63 forks source link

remove single challenge start & end date #99

Open inishchith opened 6 years ago

inishchith commented 6 years ago

fixes #97

@RishabhJain2018 please review and let me know if any changes required 😄

RishabhJain2018 commented 6 years ago

@inishchith Can you please paste the screenshot?

inishchith commented 6 years ago

screen shot 2018-08-29 at 2 25 33 am @RishabhJain2018

RishabhJain2018 commented 6 years ago

Can you please paste the screenshot after adding some good amount of content into it?

inishchith commented 6 years ago

screen shot 2018-08-29 at 9 25 27 am

@RishabhJain2018 it looks a scattered. Also just noticed this function expects a return data which this function never returns 🙈 Should i update this thread with the above fix or open a separate issue ticket for it ? 😄

guyandtheworld commented 6 years ago

@inishchith Looks like a forgotten return statement. Please feel free to open a new PR to fix this issue. Thanks for pointing it out! :+1:

inishchith commented 6 years ago

@RishabhJain2018 Let me know if the above screenshot looks good or if there's any changes to be made 😄

RishabhJain2018 commented 6 years ago

@isht3 Can you please check it on your local machine?

guyandtheworld commented 6 years ago

@RishabhJain2018 This PR is dependent on #102, we have to merge that first.

RishabhJain2018 commented 6 years ago

@isht3 Can you please test it on your local machine?

guyandtheworld commented 6 years ago

I'll review this today.

RishabhJain2018 commented 5 years ago

@isht3 Any updates on this?

guyandtheworld commented 5 years ago

@inishchith I've tested it, can you rebase and push? It'll work properly after that.

inishchith commented 5 years ago

@isht3 let me know if anymore changes required

RishabhJain2018 commented 5 years ago

@inishchith Thanks for the PR. Can you please resolve the conflicts here?

inishchith commented 5 years ago

@RishabhJain2018 Done!