Cloud-CV / origami-lib

Python package for origami
BSD 3-Clause "New" or "Revised" License
17 stars 15 forks source link

Logging with origami. #38

Open fristonio opened 6 years ago

fristonio commented 6 years ago

I was thinking that we can provide origami-lib with a logger functionality which will set up the logger for the demo. So a single method will bootstrap the python logging library which can then be used by demo user.

This will help us when we are deploying demos to our server too, suppose user want to check the logs for his demo the logger will store them in a file which can then be provided to demo owner.

Thoughts on this? @deshraj @uttu357 @AvaisP @dexter1691 @vpn1997

gupta-utkarsh commented 6 years ago

@fristonio Are you thinking of adding something on the lines of https://github.com/Cloud-CV/origami-daemon/pull/4?

fristonio commented 6 years ago

Yeah, mostly like this. This way we can log better logs without needing the user to configure anything.

gupta-utkarsh commented 6 years ago

Yeah sounds good. Also origami-lib should send logs with a certain label to the Origami web application for display to the user of the demo.

fristonio commented 6 years ago

Yeah, I have it in the todo list for origami-lib, but the thing is I didn't wanna mangle too much with the code that's already there in the frontend. We can do this easily once we have a basic working app with us.

gupta-utkarsh commented 6 years ago

Sounds good! :+1: