search

Cloud-Pipelines / pipeline-editor

Cloud Pipelines Editor is a web app that allows the users to build and run Machine Learning pipelines without having to set up development environment.
https://cloud-pipelines.net/pipeline-editor/
Apache License 2.0
55 stars 7 forks source link

Not able to delete components #1

Closed jamway closed 3 years ago

jamway commented 3 years ago

Issue Description

After dropping the component on the canvas I was not able to remove it from the canvas either by hitting delete key or trying to drag it off to the component selector

Expected behavior After selecting the component to be deleted, the user can remove it from the canvas either by hitting the delete key or drag it off to the component selector.

Thanks for putting this together. Please let me know if I am missing something obvious.

Ark-kun commented 3 years ago

Thank you for the feedback. I've realized the issue the day I've sent the announcement. I understand the frustration. When I first tried react-flow I was surprised that the deletion did not work (https://github.com/wbkd/react-flow/issues/1268) and multi-selection did not work as well (https://github.com/wbkd/react-flow/issues/1269, https://github.com/wbkd/react-flow/issues/1270)
Turns out the react-flow had Mac-only configuration that was using the Meta key for multi-selection (which translated to the Win key on Windows) and backspace for deletion. I've changed those defaults to Delete for deletion, Ctrl for multi-selection and Shift for area selection, created a PR to add support for multiple keys and forgot about it (https://github.com/wbkd/react-flow/pull/1281). Turns out it's not merged yet.

I'll work on working around this issue ASAP.

Ark-kun commented 3 years ago

This should be fixed now. Please try it out. (You need to reload reload the app by closing its tabs and opening a new one.)

jamway commented 3 years ago

Thank you. I have confirmed the delete function now works as intended!