Cloud-RF / tak-server

TAK Server docker setup
GNU General Public License v3.0
153 stars 52 forks source link

System agnostic logo replacement script #8

Closed AlexWinder closed 2 years ago

AlexWinder commented 2 years ago

The logo-replacement.sh script installs openjdk-11-jdk and imagemagick natively on the host if they don't exist.

https://github.com/Cloud-RF/tak-server/blob/2d9c769781d98899a0174099afd12677c5975b8f/scripts/logo-replacement.sh#L8-L20

A better solution would be to have a Docker container to handle the replacement. This would make the script completely independent of the host operating system.

FarrantAlex commented 2 years ago

Meh. Too much effort for a pic of a banana.