CloudBotIRC / CloudBot

CloudBot - The simple, fast, expandable, open-source Python IRC Bot!
GNU General Public License v3.0
274 stars 253 forks source link

Fetching imgur image does not work #196

Open ghost opened 8 years ago

ghost commented 8 years ago

Getting this

Traceback (most recent call last): File "/home/Chi/Cloudbot/cloudbot/plugin.py", line 376, in _execute_hook out = yield from self.bot.loop.run_in_executor(None, self._execute_hook_threaded, hook, event) File "/usr/lib/python3.4/asyncio/futures.py", line 348, in iter yield self # This tells Task to wait for completion. File "/usr/lib/python3.4/asyncio/tasks.py", line 351, in _wakeup value = future.result() File "/usr/lib/python3.4/asyncio/futures.py", line 243, in result raise self._exception File "/usr/lib/python3.4/concurrent/futures/thread.py", line 54, in run result = self.fn(_self.args, _self.kwargs) File "/home/Chi/Cloudbot/cloudbot/plugin.py", line 340, in _execute_hook_threaded return hook.function(parameters) File "/home/Chi/Cloudbot/plugins/imgur.py", line 108, in imgur reddit_url = web.try_shorten("http://reddit.com" + item.reddit_comments) AttributeError: 'GalleryImage' object has no attribute 'reddit_comments'

edwardslabs commented 8 years ago

@lukeroge I can reproduce this for any subreddit imgur search. I can't find any reference to reddit_comments in imgurpython. Did they remove it or was that attribute sourced from somewhere else?

ghost commented 8 years ago

Pretty sure it's from here

https://api.imgur.com/endpoints/gallery#subreddit

"Response Model Gallery Images with 'reddit_comments' url"

ghost commented 8 years ago

Anything new on this?