CloudBotIRC / CloudBot

CloudBot - The simple, fast, expandable, open-source Python IRC Bot!
GNU General Public License v3.0
273 stars 252 forks source link

Information Disclosure vulnerability in ping.py module #285

Open oxagast opened 5 years ago

oxagast commented 5 years ago

By design the ping module is subject to an information disclosure vulnerability. If even if the administrator of a CloudBot has it's IP address hidden by a hostmask, you can put up a firewall on your box that logs the ICMP protocol, then you .ping yourserver.com with CloudBot; it's IP will appear in your firewall logs. The only way around this 'bug' that i can devise while keeping the ping module would be to ping over a VPN or through some type of proxy that can handle ICMP, but it would be easiest just to remove it from sensitive applications imo.