CloudCannon / pagefind

Static low-bandwidth search at scale
https://pagefind.app
MIT License
3.5k stars 113 forks source link

Emojis not indexed? They return no results #405

Closed Julianoe closed 1 year ago

Julianoe commented 1 year ago

Using PageFind with tweetback I've noticed that searching for emojis return no results (issue here) Testing it on your demo page confirmed that it did not work: searching for 🌋 should return this page as a result: https://xkcd.pagefind.app/comics/2017-11-24-emoji-sports/

Is it known behavior? Would there be a way to index emojis to enable searching for them like any other caracters?

bglw commented 1 year ago

I love my emoji, so I should be able to sneak this into the upcoming 1.0 release 🎉

Currently Pagefind intentionally strips out punctuation when indexing, so emojis will be getting caught in that net. I'll make a test case tomorrow and get it to pass 🌋

Watch this space 👀

bglw commented 1 year ago

Hey @Julianoe 👋

The latest Pagefind beta (1.0.0-beta.1) includes support for emoji. There are also a couple of changes on the beta, most notably a rename from the default /_pagefind/ to /pagefind/, which I haven't finalized a set of release notes for.

Let me know if you give this a go! It will be part of a full 1.0 release next week or so, so no worries if you just want to wait til then 🙂

In lieu of running it, here's the new test that now passes: https://raw.githubusercontent.com/CloudCannon/pagefind/main/pagefind/features/characters.feature (Search Pagefind matches emoji)

bglw commented 1 year ago

Hey @Julianoe ! 👋

Good news — this has landed in Pagefind v1.0.0! ✨

See the full release notes here: https://github.com/CloudCannon/pagefind/releases/tag/v1.0.0 💙

Julianoe commented 1 year ago

Awesome! Thanks!