search

CloudCannon / pagefind

Static low-bandwidth search at scale
https://pagefind.app
MIT License
3.4k stars 106 forks source link

Please update microjson #421

Closed pbsds closed 12 months ago

pbsds commented 1 year ago

Hi, I'm packaging pagefind into nixpkgs, and we struggle with git dependencies in cargo.

You seem to include a git reference to microjson:

https://github.com/CloudCannon/pagefind/blob/57507610870a1dcf94f10ce79604e43542a68df0/Cargo.lock#L1676-L1679

Could you update this to a non git+... dependency? Much appreciated.

bglw commented 1 year ago

Hi @pbsds — good to know!

I have another change to include in a 1.0.1, so I can include this. I'm blocked by a bug on the crates release of microjson, but I can do a temporary fork and publish a crate at that commit to unblock you. Will be in touch later today

pbsds commented 1 year ago

There is a 50/50 chance a reviewer will find it problematic or not that i vendor the lock as a fix so it is not a total block, but please do keep me posted.

Congrats on 1.0.0 :rocket:

bglw commented 1 year ago

Just publishing a 1.0.1-rc1 release now to test both fixes — should have something out today assuming nothing else comes up 👍

bglw commented 12 months ago

Hi @pbsds — this should now be resolved in v1.0.1 by using pagefind_microjson while we wait for a microjson stable release. Let me know if you're still seeing any issues!