search

CloudCheckr / Developer-Community

A public repository of scripts for utilizing the CloudCheckr API
https://success.cloudcheckr.com
MIT License
31 stars 17 forks source link

Core api delete account #38

Closed ChrisOngCC closed 4 years ago

ChrisOngCC commented 4 years ago

Per Iuvany, a script was provided to me and asked to be uploaded to GitHub, this is not my script. It was given to me in a Zip file with other data files, all non-python files have been omitted, script has not been altered by me either, although, I think it can use an update with its comments as it seems dated and/or looks to have been altered at some point from user to account mangement.

ChrisOngCC commented 4 years ago

Please see my comment above, not sure who (customer) asked for this on GH, but if you think further review should be done on the functionality of the script/documentation, I can review/test, else, per Iuvany's request, I will merge PR.

ChrisOngCC commented 4 years ago

Added an example log file and data file with instructions on how to use the script and generate the data file

alecrajeev commented 4 years ago

I think a nice readme would be helpful as well. Happy to hop on a quick zoom to review any questions.

ChrisOngCC commented 4 years ago

@alecrajeev changes completed, pending your review. Though in line 7, is pathlib still needed? I don't recall that library being used