search

CloudClub-uoft / cloud-club-website

Club Website
https://cloudclub.ca
4 stars 4 forks source link

St c0nst patch profile image #91

Closed st-C0nst closed 2 years ago

st-C0nst commented 2 years ago

Added display for the user's profile picture for forum posts. If the user does not have a profile picture an image with the users email initials will be displayed.

harsimrat99 commented 2 years ago

Hi @st-C0nst ,

Thank you for making the requested changes. Please take a look at my comments above and it would be helpful if you could please make the requested corrections.

I would also to ask if you could please run all tests inside the frontend directory before any submissions.

Please let me know if there are any questions.

Thank you, Harsimrat

harsimrat99 commented 2 years ago

Hi @st-C0nst ,

Thank you for taking the time to look at this PR.

Please merge the latest staging branch into this branch before making any more changes as it is significantly behind that one.

I see that console.log statements have not been removed as indicated in my previous comments. Please remove them.

Additionally, please do more error checking and corner case checking for your query on line :

db.query(SELECT profile_path FROM cloudclub.profiles WHERE userid='${result[0].userid}' , (err2, profilePathResult) => {

What if profilePathResult is undefined? Or empty? That is throwing an error.

Thank you, Harsimrat

harsimrat99 commented 2 years ago

Thank you @st-C0nst . Closing and merging this PR.