CloudCredo / cloudrocker

Apache License 2.0
34 stars 6 forks source link

go sample does not fock build #3

Closed jbayer closed 9 years ago

jbayer commented 9 years ago

$ fock build Starting the CloudFocker container... Running Buildpacks... -------> Buildpack version 1.1.0 ! A .godir is required. For instructions: ! http://mmcgrana.github.io/2012/09/getting-started-with-go-on-heroku Started the CloudFocker container. Deleting the CloudFocker container... cloudfocker-staging Deleted container. 2014/12/13 19:38:34 Staging failed - have you added a buildpack for this type of application? vagrant@ubuntu-14:/vagrant/sample-apps/go$ fock buildpacks go-buildpack java-buildpack

jchesterpivotal commented 9 years ago

Possibly the .godir thing.

The upstream code we follow for the golang BP requires a .godir file to be present with the name of the built executable; but launching on CF actually follows either a Procfile, manifest command or -c option.

jbayer commented 9 years ago

the .godir is there, but it has a link to example.com/server and when i go build it creates a binary named go in the directory, so that looks like a mismatch to me.

hatofmonkeys commented 9 years ago

I think this is another issue related to https://www.pivotaltracker.com/story/show/92252742 .

hatofmonkeys commented 9 years ago

Fixed in https://github.com/CloudCredo/cloudrocker/commit/ebfe01cd1adecaca99d69d2074eaaef5f0bfde50 .