search

CloudHealth / helm

Apache License 2.0
8 stars 14 forks source link

[ENG-47451] Pass region to the Collector Agent #102

Closed satyamsinghh closed 1 year ago

satyamsinghh commented 1 year ago

Pass Region to the Agent. If not set, then default value "us-east-1" would be used Jira: https://cloudhealthtech.atlassian.net/browse/ENG-47451

vmwclabot commented 1 year ago

@satyamsinghh, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

gm-cht commented 1 year ago

@satyamsinghh This is a helm chart for an agent that is installed on a customer's Kubernetes cluster. This should not have chtRegion as a parameter at all.. It communicates at the endpoint https://containers-api.edge.cloudhealthtech.com. This is a DNS entry and is not region specific at all.

gm-cht commented 1 year ago

@satyamsinghh This is a helm chart for an agent that is installed on a customer's Kubernetes cluster. This should not have chtRegion as a parameter at all.. It communicates at the endpoint https://containers-api.edge.cloudhealthtech.com. This is a DNS entry and is not region specific at all.

NVM.. I just saw the other cp-containers PR..

satyamsinghh commented 1 year ago

Need to change version in Chart.yml to 4.2.0

@gm-cht Updated chart version to 4.2.0

gm-cht commented 1 year ago

Added a new commit with a values.schema.json that can be used to restrict regions we support. This actually prevents users from installing with an unsupported region. Will review this with team.

We also need to wait for a new collector image generated from this PR: https://github.com/CloudHealth/cp-containers/pull/1420 and update the image tag in values.yaml and update appVersion in Chart.yml before we can merge this PR..

cc @satyamsinghh