CloudHealth / helm

Apache License 2.0
8 stars 15 forks source link

Adding icon and category for TMC catalog #104

Closed lucasmarzocco closed 10 months ago

lucasmarzocco commented 10 months ago

Currently, adding Cloudhealth helm repo shows the cloudhealth-collector helm chart but displays no category (can't sort) and no icon like all of the bitnami repos do. This should change that.

Screenshot 2023-10-19 at 2 53 25 PM
vmwclabot commented 10 months ago

@lucasmarzocco, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot commented 10 months ago

@lucasmarzocco, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

gm-cht commented 10 months ago

@lucasmarzocco Check this PR out: https://github.com/CloudHealth/helm/pull/102/files. I was adding an icon there anyway..

For the category field, helm does not allow a new field in Chart.yml. I added category: Cost to annotations in the above mentioned PR.

As of [v3.3.2](https://github.com/helm/helm/releases/tag/v3.3.2), additional fields are not allowed. The recommended approach is to add custom metadata in annotations. https://helm.sh/docs/topics/charts/

Let me know if it works.

lucasmarzocco commented 10 months ago

@gm-cht: Should I close this MR if you're going to merge the same changes in yours? When do you expect to have them merged and ready to be used?

gm-cht commented 10 months ago

Yes. This PR can be closed. The other PR will be merged early next week..

gm-cht commented 10 months ago

Release 4.2.0 of the helm chart (currently being tested) has these changes.

vmwclabot commented 10 months ago

@lucasmarzocco, your company's legal contact did not review your signed contributor license agreement within the 14 day limit. The merge can not proceed. Click here to resign the agreement.