search

CloudHealth / helm

Apache License 2.0
8 stars 14 forks source link

fix values json schema for apiToken #108

Closed smcavallo closed 10 months ago

smcavallo commented 10 months ago

remove apiToken as a required value in the values json schema. It is not a required value - https://github.com/CloudHealth/helm/blob/main/charts/cloudhealth-collector/templates/secrets.yaml#L6-L16 If it is set, this chart will create the cloudhealth-config secret. If it is not set, end users can manage their own cloudhealth-config secrets and values outside of this chart (which most may want to do for security reasons.)

This chart is currently broken for anyone managing their own secret:

Error: values don't meet the specifications of the schema(s) in the following chart(s):
cloudhealth-collector:
- apiToken: Does not match pattern '^.{6,48}$'

This fixes that by making apiToken not required.

Signed-off-by: smcavallo smcavallo@hotmail.com

vmwclabot commented 10 months ago

@smcavallo, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot commented 10 months ago

@smcavallo, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

vmwclabot commented 10 months ago

@smcavallo, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

Minimum required personal information is Name (First and Last) and Address (Country, State, Town/City).

vmwclabot commented 10 months ago

@smcavallo, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

smcavallo commented 10 months ago

@susanegleason - hoping this can be reviewed and merged. I have signed the contributor license agreement

vmwclabot commented 10 months ago

@smcavallo, VMware has approved your signed contributor license agreement.