Closed smcavallo closed 10 months ago
@smcavallo, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.
@smcavallo, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:
Minimum required personal information is Name (First and Last) and Address (Country, State, Town/City).
@smcavallo, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.
@susanegleason - hoping this can be reviewed and merged. I have signed the contributor license agreement
@smcavallo, VMware has approved your signed contributor license agreement.
remove
apiToken
as a required value in the values json schema. It is not a required value - https://github.com/CloudHealth/helm/blob/main/charts/cloudhealth-collector/templates/secrets.yaml#L6-L16 If it is set, this chart will create thecloudhealth-config
secret. If it is not set, end users can manage their owncloudhealth-config
secrets and values outside of this chart (which most may want to do for security reasons.)This chart is currently broken for anyone managing their own secret:
This fixes that by making
apiToken
not required.Signed-off-by: smcavallo smcavallo@hotmail.com