search

CloudHealth / helm

Apache License 2.0
8 stars 15 forks source link

cloudhealth-collector pod gets restarted due to emptydir #119

Closed bbilali closed 3 months ago

bbilali commented 3 months ago

Currently there’s no limit for the amount of memory the emptydir can consume, according to https://github.com/kubernetes/kubernetes/issues/119611 this may end up crashing the node as the memory limit is not being considered when using emptydir (the emptydir can consume all the memory of the node, resulting in other processes being killed). Setting the limit to half of the allocated memory should be fine.

vmwclabot commented 3 months ago

@bbilali, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot commented 3 months ago

@bbilali, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

kscherme commented 3 months ago

Thank you for your contribution! Our team will take a look in the next few days.

kscherme commented 3 months ago

Thank you for your patience! We are in contact with the Open Source team regarding your contributor license agreement and will get back to you once it is reviewed

vmwclabot commented 3 months ago

@bbilali, VMware has approved your signed contributor license agreement.