CloudHealth / helm

Apache License 2.0
8 stars 15 forks source link

Fix nil-pointer issue in values dnsConfig in v2.0.7 #86

Closed juanfe2793 closed 1 month ago

juanfe2793 commented 1 year ago

Description

The helm chart version 2.7.0 are triggering the following error message:

failed exit status 1: Error: template: cloudhealth-collector/templates/deployment.yaml:75:19: executing cloudhealth-collector/templates/deployment.yaml at <.Values.dnsConfig>: nil pointer evaluating interface {}.dnsConfig Use --debug flag to render out invalid YAML

Error: template: cloudhealth-collector/templates/deployment.yaml:80:33: executing cloudhealth-collector/templates/deployment.yaml at <.Values.dnsConfig.ndots>: nil pointer evaluating interface {}.dnsConfig

I propose the modification in deployment.yaml to avoid the nil pointer issues with the implementation of a variable in the 'if' validation. I also propose some fixes with indentation.

PR includes.

vmwclabot commented 1 year ago

@juanfe2793, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot commented 1 year ago

@juanfe2793, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

vmwclabot commented 1 year ago

@juanfe2793, your company's legal contact has approved your signed contributor license agreement. It will also be reviewed by VMware, but the merge can proceed.

vmwclabot commented 1 year ago

@juanfe2793, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

Please provide an actual name and address Please provide the name of the organization you are affiliated with or indicate none

vmwclabot commented 1 year ago

@juanfe2793, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

vmwclabot commented 1 year ago

@juanfe2793, your company's legal contact has approved your signed contributor license agreement. It will also be reviewed by VMware, but the merge can proceed.

vmwclabot commented 1 year ago

@juanfe2793, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

Please provide the name of the organization you are affiliated with or indicate none. Please provide an actual name.

Preskton commented 1 year ago

Hi, @gm-cht and @kscherme -- I'm not sure who to ask about this, but we (Twilio) have signed the generic VMware CLA. Is there a different CLA we need to sign to contribute to this project?

kscherme commented 1 year ago

Hi, @gm-cht and @kscherme -- I'm not sure who to ask about this, but we (Twilio) have signed the generic VMware CLA. Is there a different CLA we need to sign to contribute to this project?

Hi @Preskton, I am not sure about the CLA. I am seeing this as the reason that the CLA is not being accepted:

Please provide the name of the organization you are affiliated with or indicate none. Please provide an actual name.

Can you try going through the link again?

pkchavva commented 1 year ago

Hi, @gm-cht and @kscherme -- I'm not sure who to ask about this, but we (Twilio) have signed the generic VMware CLA. Is there a different CLA we need to sign to contribute to this project?

Checking with our Open Source office to see whats going on. Will keep you posted.