search

CloudNationHQ / terraform-azure-aks

Terraform module which creates azure kubernetes resources used by workloads and accelerators.
https://library.tf/modules/CloudNationHQ/aks/azure/latest
MIT License
0 stars 1 forks source link

Starting from AKS 1.28 max_surge is set to 10% #51

Closed cveld closed 2 months ago

cveld commented 4 months ago

As per https://github.com/hashicorp/terraform-provider-azurerm/issues/24020 since AKS 1.28 max_surge is set to 10% for the default node pool by default.

Currently the module always reports a change on the max_surge setting from 10% to NULL when left to the defaults.

Desired situation: The module should default to max_surge 10%.

Considerations: AKS 1.27 is an LTS version. For customers running the defaults they will see a one time max_surge change from NULL to 10%. This seems a reasonable change as in line with the general kubernetes guidance.

Potentially this could be fixed in a future version of the azurerm provider as well which renders this request for a module patch unnecessary.

dkooll commented 2 months ago

This is a upstream provider or rest api issue. In collaboration with Carl decided to close this one.