CloudNationHQ / terraform-azure-vnet

Terraform module which creates virtual network resources used by workloads and accelerators.
https://library.tf/modules/CloudNationHQ/vnet/azure/latest
MIT License
1 stars 1 forks source link

Example usage nsg rules is not correct #29

Closed MartijnCN closed 4 months ago

MartijnCN commented 5 months ago

The example does not work for nsg rules:

usage example:

   sql = {
    cidr        = var.vnet.subnets.sql.cidr
    route_table = "rt"
    nsg = {
      rules = local.rules
    }
  }

Should be to make it work:

  sql = {
    cidr        = var.vnet.subnets.sql.cidr
    route_table = "rt"
    rules       = local.rules
  }
cndaan commented 4 months ago

Are you sure @MartijnCN

Works with the provided example for me, i used this:

      bastion = {
        name = "AzureBastionSubnet"
        cidr = [var.bastion_cidr]
        nsg = {
          rules = local.rules
        }
      }
dkooll commented 4 months ago

solved by #34