search

CloudNativeDataPlane / cndp

Cloud Native Data Plane (CNDP) is a collection of user space libraries to accelerate packet processing for cloud applications using AF_XDP sockets as the primary I/O..
BSD 3-Clause "New" or "Revised" License
90 stars 32 forks source link

pre-commit: integrate with cndp #373

Closed maryamtahhan closed 5 months ago

maryamtahhan commented 5 months ago

Install pre-commit for CNDP + its configuration. Remove old githook.

maryamtahhan commented 5 months ago

Sorry for the noise - it took a while to find the right recipe of clang versions between pre-commit hooks and the github action

maryamtahhan commented 5 months ago

:) Markdown linter disconnect now :(

KeithWiles commented 5 months ago

Should this get merged now or will you be fixing the Lint Code Base issues?

maryamtahhan commented 5 months ago

I will fix them :)

maryamtahhan commented 5 months ago

Linting issues are now fixed. I just rebased there and kicked off the github actions again. As soon as they complete we should be good.

Sorry again for all the noise :( I couldn't reproduce the issues locally

maryamtahhan commented 5 months ago

Going to close this. Will do some retest and send up a new branch.

I have to head away and there's 1 or 2 things I'm not fully happy with - Sorry.

KeithWiles commented 5 months ago

No problem it is a lot of work, Thanks