Reader doesn't log 200/204 coming from the Adaptor sometimes

CloudNativeSDWAN / cnwan-reader

Watch changes to your service registry and react to them.

Apache License 2.0

6 stars 6 forks source link

Reader doesn't log 200/204 coming from the Adaptor sometimes #9

Open arnatal opened 4 years ago

arnatal commented 4 years ago

Under certain conditions (unclear yet) the Reader seems to not log (maybe not even receive?) the 200 or 204 confirmations from the Adaptor, while other response codes like 207 or 503 are logged. Further investigation is required.

ljakab commented 3 years ago

I would have to investigate this further, but my educated guess is that it is timeout related. When the adaptor receives an event, it handles it synchronously and doesn't send a reply to the reader until it is able to apply the changes to vManage. If this takes longer than the timeout set in the reader, the reply may be missed.

asimpleidea commented 3 years ago

I would have to investigate this further, but my educated guess is that it is timeout related. When the adaptor receives an event, it handles it synchronously and doesn't send a reply to the reader until it is able to apply the changes to vManage. If this takes longer than the timeout set in the reader, the reply may be missed.

Maybe, but I doubt the time out is involved because no timeout error is thrown by the cnwan reader, it just doesn't receive the response from the OpenAPI generated code as if no response was even sent but just continues working as usual. I need to re-read that part of the code and/or the OpenAPI yaml.

asimpleidea commented 3 years ago

Adding a bit more to the conversation:

every other code comes immediately, it's just 200 and 204 that do not
when both reader and adaptor run on the same machine, then this error does not happen and every response code is caught immediately.