search

CloudNetService / CloudNet

A modern application that can dynamically and easily deliver Minecraft oriented software
https://cloudnetservice.eu
Apache License 2.0
381 stars 120 forks source link

feat: New plugin made to support LuckPerms #1258

Closed RobotHanzo closed 5 months ago

RobotHanzo commented 1 year ago

Motivation

In PR #1253 CloudPerms was removed, making LuckPerms one of the best alternatives But it lacks the feature of service / task exclusive permission Therefor an optional plugin was made for those who want to use LuckPerms and use task exclusive permissions

Modification

Added a new plugin named CloudNet-LuckPerms-Addon to add some LuckPerms context (explained below)

Result

image Four types of context were added: task, service, environment and node Server admins may then setup context in their permissions if needed, to make a permission service / task exclusive (Note: I only made the plugins for platforms which both CloudNet and LuckPerms support, and this has been tested on Paper & Velocity)

Other context

N/A

RobotHanzo commented 1 year ago

Done.

derklaro commented 1 year ago

Just want to throw this information here: we're planning on a seperate module to better support luckperms (for example auto downloading for the environments). I think this plugin would fit more into the module (or, we can leave it as a plugin but the LP code will be in a seperate repo anyway).

So this PR won't be merged here, but having that functionality seems like a great addition.

RobotHanzo commented 1 year ago

Just want to throw this information here: we're planning on a seperate module to better support luckperms (for example auto downloading for the environments). I think this plugin would fit more into the module (or, we can leave it as a plugin but the LP code will be in a seperate repo anyway).

So this PR won't be merged here, but having that functionality seems like a great addition.

Alright, I'd be glad to move this feature into the module when it's made

0utplay commented 5 months ago

Hi @RobotHanzo, it took longer than we expected. But currently I am working the last preparations to remove cloudperms. The idea to create a new luckperms module is on ice (at least for now). So I would like to include the plugin you developed.

Can you maybe update this pr to RC10 and the latest minecraft version (1.20.4 is enough for now). If you don't have the time to do that, just leave a message and I will try to update the pr.

RobotHanzo commented 5 months ago

Hi @RobotHanzo, it took longer than we expected. But currently I am working the last preparations to remove cloudperms. The idea to create a new luckperms module is on ice (at least for now). So I would like to include the plugin you developed.

Can you maybe update this pr to RC10 and the latest minecraft version (1.20.4 is enough for now). If you don't have the time to do that, just leave a message and I will try to update the pr.

Done

0utplay commented 5 months ago

Please exec gradlew spotlessApply once

RobotHanzo commented 5 months ago

I just discovered that context suggestions are supported, so I added that (Which I believe adds our contexts to the web panel for easier access)

0utplay commented 5 months ago

Thanks for the contribution!