CloudNetService / CloudNet

A modern application that can dynamically and easily deliver Minecraft oriented software
https://cloudnetservice.eu
Apache License 2.0
371 stars 115 forks source link

fix: check that bridge properties are present before access #1317

Closed 0utplay closed 9 months ago

0utplay commented 10 months ago

Motivation

The method to fill common placeholders is used for cloudnet signs too and as the service is starting the signs are trying to resolve some of the bridge properties. That fails because the service is just starting and the bridge is not loaded yet.

Modification

Added a check that makes sure that we are only replacing placeholders if they are present.

Result

Signs are working correctly again.

github-actions[bot] commented 10 months ago

Test Results

  47 files  ±0    47 suites  ±0   1m 30s :stopwatch: +11s 394 tests ±0  394 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  724 runs  ±0  724 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 71fba2af. ± Comparison against base commit 102853cd.

:recycle: This comment has been updated with latest results.