CloudNetService / CloudNet

A modern application that can dynamically and easily deliver Minecraft oriented software
https://cloudnetservice.eu
Apache License 2.0
367 stars 115 forks source link

fix: tasks setup does not allow skipping proxy fallback settings #1387

Closed 0utplay closed 2 months ago

0utplay commented 2 months ago

Motivation

When using the tasks setup to create a new proxy task the setup asks to provide a default fallback task for the proxy. Due to a change to our jline handling the question does not allow empty answers anymore.

Modification

The setup now allows "none" as answer instead of an empty string.

Result

The setup is working correctly again

github-actions[bot] commented 2 months ago

Test Results

 47 files  ±0   47 suites  ±0   1m 20s :stopwatch: +6s 395 tests ±0  395 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  726 runs  ±0  726 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 759aa8ba. ± Comparison against base commit 94ca88dd.

This pull request removes 26 and adds 26 tests. Note that renamed tests count towards both. ``` eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [10] 12665, null eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [1] {test2=test3, test=test1}, class java.lang.String, class java.lang.String eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [23] 2024-03-21T08:15:49.273271413Z eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [24] 2024-03-21T08:07:29.273274579Z eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] KYSNUZR2BN03C72EWLM15NJE5, null eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] {test2=456, test=123}, class java.lang.String, class java.lang.Integer eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [38] 2024-03-21 eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] 1386619252, null eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] Lobbyhello156:be8f7efe-e4d8-4b82-9d21-4ae36e858897 eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] {test2=[678, 456], test=[123, 456]}, class java.lang.String, java.util.List … ``` ``` eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [10] 23799, null eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [1] {test=test1, test2=test3}, class java.lang.String, class java.lang.String eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [23] 2024-04-15T17:07:11.222035468Z eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [24] 2024-04-15T16:58:51.222038844Z eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] HSLKW9YC4SLJQC46ZPXDQS08H, null eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] {test=123, test2=456}, class java.lang.String, class java.lang.Integer eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [38] 2024-04-15 eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] -1067412125, null eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] Lobbyhello156:6af8da4d-d37c-4daf-8f39-967a353a4cfe eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] {test=[123, 456], test2=[678, 456]}, class java.lang.String, java.util.List … ```