CloudNetService / CloudNet

A modern application that can dynamically and easily deliver Minecraft oriented software
https://cloudnetservice.eu
Apache License 2.0
367 stars 115 forks source link

fix: ensure that the java.class.path property returns the correct classpath #1411

Closed 0utplay closed 1 month ago

0utplay commented 1 month ago

Motivation

Due to the fact that we use the wrapper to start the application the jvm misses to add the platform jar to the classpath. But we also can't add the platform to the classpath before the wrapper is not started as this would cause us to start the platform directly.

Modification

After the wrapper is started we append the platform jar to the class path property. Therefore the jar is not loaded directly but is still part of the class path property and platforms can depend on the property.

Result

Platforms can depend on the default java behaviour which is to add the own platform to the cp.

Other context

https://discord.com/channels/325362837184577536/818777626663321671/1243214044853309483)

github-actions[bot] commented 1 month ago

Test Results

 47 files  ±0   47 suites  ±0   1m 14s :stopwatch: -11s 395 tests ±0  395 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  726 runs  ±0  726 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 613ea57b. ± Comparison against base commit 726d42ab.