CloudNetService / CloudNet

A modern application that can dynamically and easily deliver Minecraft oriented software
https://cloudnetservice.eu
Apache License 2.0
367 stars 115 forks source link

feat: replace custom logging with slf4j & logback #1414

Closed 0utplay closed 6 days ago

0utplay commented 1 month ago

Motivation

Currently our logging uses some self-written wrapper around JUL instead of the de-facto standard logging library SLF4J. This means that users need to understand our logging implementation and, for example, debug messages from libraries that we're using are never displayed.

Modification

Replace our self-written JUL-wrapper with SLF4J and logback.

Result

SLF4J is in used as the logging library, using the widely used logback implementation.

github-actions[bot] commented 1 month ago

Test Results

 44 files  ±0   44 suites  ±0   1m 36s :stopwatch: -5s 414 tests ±0  414 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  745 runs  ±0  745 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 8522566e. ± Comparison against base commit af2222d5.

This pull request removes 34 and adds 34 tests. Note that renamed tests count towards both. ``` eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"hello":"world","this":"is","insane":"!"}}, PRETTY eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [23] 16:55:27.795476768 eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [28] 16:55:27.795529237Z eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [29] 16:55:27.795547872Z eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [30] 16:55:27.795555888+05:00 eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [31] 16:55:27.795570114-03:00 eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [34] 2024-07-01T16:55:27.795599269 eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [39] 2024-07-01T16:55:27.795649754Z eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [4] 2024-07-01T16:55:27.791437223Z eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [5] 2024-07-01T16:47:07.791442723Z … ``` ``` eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"this":"is","hello":"world","insane":"!"}}, PRETTY eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [23] 17:21:52.908935601 eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [28] 17:21:52.908989623Z eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [29] 17:21:52.909009951Z eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [30] 17:21:52.909017976+05:00 eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [31] 17:21:52.909035389-03:00 eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [34] 2024-07-01T17:21:52.909064294 eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [39] 2024-07-01T17:21:52.909117664Z eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [4] 2024-07-01T17:21:52.908739142Z eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [5] 2024-07-01T17:13:32.908742148Z … ```

:recycle: This comment has been updated with latest results.