CloudNetService / CloudNet

A modern application that can dynamically and easily deliver Minecraft oriented software
https://cloudnetservice.eu
Apache License 2.0
367 stars 115 forks source link

fix: ignore fabric fake players when getting player information #1425

Closed 0utplay closed 1 week ago

0utplay commented 1 week ago

Motivation

https://modrinth.com/mod/carpet supports fake players which cause some problems for our fabric implementation.

Modification

Added a check to ensure that the players handled by the bridge are real players and not fake ones.

Result

Fake players are ignored and https://modrinth.com/mod/carpet is working fine with cloudnet.

github-actions[bot] commented 1 week ago

Test Results

 44 files   44 suites   1m 37s :stopwatch: 414 tests 414 :white_check_mark: 0 :zzz: 0 :x: 745 runs  745 :white_check_mark: 0 :zzz: 0 :x:

Results for commit caeee157.

:recycle: This comment has been updated with latest results.