CloudNetService / CloudNet

A modern application that can dynamically and easily deliver Minecraft oriented software
https://cloudnetservice.eu
Apache License 2.0
376 stars 119 forks source link

fix: schedule no tasks when signs are disabled #1486

Closed 0utplay closed 1 month ago

0utplay commented 1 month ago

Motivation

When the sign plugin (on nukkit & bukkit) is being disabled we might receive a service update which causes a task schedule. The task schedule then causes an exception.

Modification

Added a check to only schedule tasks when the plugin is enabled

Result

No exceptions when stopping the signs plugin.

github-actions[bot] commented 1 month ago

Test Results

 48 files  ±0   48 suites  ±0   2m 8s :stopwatch: -10s 420 tests ±0  420 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  751 runs  ±0  751 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit af22af27. ± Comparison against base commit e91f1ea3.