CloudNetService / CloudNet

A modern application that can dynamically and easily deliver Minecraft oriented software
https://cloudnetservice.eu
Apache License 2.0
376 stars 119 forks source link

fix: checks for minimum service heap memory #1518

Closed 0utplay closed 1 week ago

0utplay commented 1 week ago

Motivation

The process config states that at least 50mb of memory are needed. The check in the builder was checking for memory > 50 thus not including 50mb.

Modification

Made the check in the builder inclusive and added the correct range to the command.

Result

Correct checks for heap memory in the builder & commands

github-actions[bot] commented 1 week ago

Test Results

 48 files  ±0   48 suites  ±0   1m 51s :stopwatch: +4s 420 tests ±0  420 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  751 runs  ±0  751 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit a8af7ea5. ± Comparison against base commit 115d24bb.

This pull request removes 37 and adds 37 tests. Note that renamed tests count towards both. ``` eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"this":"is","insane":"!","hello":"world"}}, PRETTY eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [14] 2024-09-26 eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [23] 08:08:16.170691053 eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [28] 08:08:16.170879586Z eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [29] 08:08:16.170902058Z eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [30] 08:08:16.170927045+05:00 eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [31] 08:08:16.170946321-03:00 eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [34] 2024-09-26T08:08:16.170962882 eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [39] 2024-09-26T08:08:16.171074551Z eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [4] 2024-09-26T08:08:16.170575917Z … ``` ``` eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"hello":"world","insane":"!","this":"is"}}, PRETTY eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [14] 2024-09-28 eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [23] 18:37:05.086235275 eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [28] 18:37:05.086402918Z eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [29] 18:37:05.086426101Z eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [30] 18:37:05.086447411+05:00 eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [31] 18:37:05.086466216-03:00 eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [34] 2024-09-28T18:37:05.086484240 eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [39] 2024-09-28T18:37:05.086598834Z eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [4] 2024-09-28T18:37:05.086136230Z … ```