CloudNetService / CloudNet

A modern application that can dynamically and easily deliver Minecraft oriented software
https://cloudnetservice.eu
Apache License 2.0
378 stars 120 forks source link

Bad classes in gomint #185

Closed nklyshko closed 4 years ago

nklyshko commented 4 years ago

Describe the bug

Can't build cloudnet modules because of newer java version clasess in gomint.

Steps for reproducing

./gradlew cloudnet-modules:cloudnet-bridge:build

Message

> Task :cloudnet-modules:cloudnet-bridge:compileJava FAILED
D:\Work\CloudNet\cloudnet-modules\cloudnet-bridge\src\main\java\de\dytanic\cloudnet\ext\bridge\gomint\event\GoMintBridgeEvent.java:3: error: cannot access Event
import io.gomint.event.Event;
                      ^
  bad class file: D:\Work\CloudNet\cloudnet-modules\libs\gomint-1.0-SNAPSHOT.jar(io/gomint/event/Event.class)
    class file has wrong version 55.0, should be 52.0
    Please remove or make sure it appears in the correct subdirectory of the classpath.
FAILURE: Build failed with an exception.

Please provide us information about your environment and used assets

OS: Windows 7 Version: Last master commit

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.94. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

derrop commented 4 years ago

You have to build it using Java 11

nklyshko commented 4 years ago

I think that gradle manages which version to use to build. Should I change sourceCompatibility to 1.11?

derrop commented 4 years ago

No, you don't have to change anything in CloudNet itself. It's only your jdk version

juliarn commented 4 years ago

Yes, you have to build with Java 11. We can't do much about this, gomint seems to be closed, but we dont want to remove the whole support for it yet

nklyshko commented 4 years ago

Is it correct, that if something can't be built using Java 8, but can with Java 11, then it must be have sourceCompatibility 1.11?

juliarn commented 4 years ago

Not really, we only use java 8 features, so the source compatibility should be 8 too.