Rename OMUSE Dales grid names

CloudResolvingClimateModeling / dales

Dutch Atmospheric Large-Eddy Simulation model

GNU General Public License v3.0

1 stars 0 forks source link

Rename OMUSE Dales grid names #11

Closed goord closed 5 years ago

goord commented 5 years ago

grids should be fields
nudging should be nudging_profiles
forcings should be forcing_profiles

This all has to be changed in

The OMUSE interface code
The examples in OMUSE and python-note
The examples in https://github.com/CloudResolvingClimateModeling/dales-omuse-examples
The paper table
The paper code snippets

fjansson commented 5 years ago

more renaming: forcings[:].tendency_THL -> forcings[:].THL etc

goord commented 5 years ago

More renaming:

Pressure should be denoted with P, modified pressure with pi
Rain should be denoted with QR
Replace LWP, TWP and RWP with QL, QT and QR

goord commented 5 years ago

I guess we want to remove the function

DalesInterface.get_field(self, field, imin=1, imax=None, jmin=1, jmax=None, kmin=1, kmax=None)
DalesInterface.set_field(self, field, a, imin=1, jmin=1, kmin=1):

because they are essentially duplicated by the grid interface

goord commented 5 years ago

Furthermore it may be useful to include the paper table containing this information in the Sphinx documentation as well

fjansson commented 5 years ago

Replace LWP, TWP and RWP with QL, QT and QR

This may be confusing, since the LWP, TWP, RWP are integrated over the vertical direction (liquid water path etc), while QL, QT, QR are generally just local values.

About removing get_field, set_field - they are in Dales, not DalesInterface, right? I agree they could go. Then maybe get_profile() can be removed as well? The get_profile_U etc are in principle also replaced by the grid interface, but 1) we still use them in sp-coupler, 2) The grid interface async functionality isn't quite there yet, while these functions work asynchronously. So they should stay for now.

goord commented 5 years ago

Replace LWP, TWP and RWP with QL, QT and QR

This may be confusing, since the LWP, TWP, RWP are integrated over the vertical direction (liquid water path etc), while QL, QT, QR are generally just local values.

Ok, but the profiles are also averaged and still denoted with the same letter. But I agree that the vertical integration should be clearly distinguishable from say a the lowest full level level slice

fjansson commented 5 years ago

yes if the grid name would indicate vertical integration, I'd be fine with naming them QL etc. But now they are in the surface_fields grid, so it's not clear.

goord commented 5 years ago

Ok let's stick to the current naming scheme, I don't feel like inventing yet another grid. I will just add extra entries to the table of variables