search

CloudSixteen / Clockwork

A roleplaying framework developed by Cloud Sixteen for the people.
http://CloudSixteen.com
MIT License
44 stars 44 forks source link

Add more possibilties for plugin creators when using thirdperson #519

Closed karl-police closed 5 years ago

VortixDev commented 5 years ago

Thanks for the PR, though if someone wants to use the setup of the existing third person plugin whilst implementing their own system, they can override the relevant functions - a "custom third person" mechanic is not needed for this.

karl-police commented 5 years ago

@VortixDev The mechanic does not add any disadvantages to the current one

karl-police commented 5 years ago

@VortixDev also it doesn't need to be overriden anymore it can but it doesn't have to

sanny-io commented 5 years ago

The disadvantage to this is that it's unnecessary. It's another way to do something that is already easily accomplished.

karl-police commented 5 years ago

The disadvantage to this is that it's unnecessary. It's another way to do something that is already easily accomplished.

don't you get it that overriding is not really a nice thing?

FilmsActionCZ commented 5 years ago

+support

sounds lit

sanny-io commented 5 years ago

don't you get it that overriding is not really a nice thing?

In this case, I don't see anything wrong with an override. What I think would be even better is if there was a hook that was called to enable third person. If the hook doesn't return anything, then the default third person will activate.

Or put the default function in the Clockwork table.

karl-police commented 5 years ago

don't you get it that overriding is not really a nice thing?

In this case, I don't see anything wrong with an override. What I think would be even better is if there was a hook that was called to enable third person. If the hook doesn't return anything, then the default third person will activate.

you have to know that player NWBool is set per client not for everyone at the same time, each has a different value, there is no problem. This is the best solution I come with.