search

CloudSnorkel / cdk-github-runners

CDK constructs for self-hosted GitHub Actions runners
https://constructs.dev/packages/@cloudsnorkel/cdk-github-runners/
Apache License 2.0
255 stars 37 forks source link

Runner image customization #26

Closed kichik closed 1 year ago

kichik commented 2 years ago

User should be able to install additional dependencies, setup internal repositories, and in general fully customize the image to their needs.

sercantor commented 1 year ago

@kichik does this include build flags? my actions job fails, and when I look at the logs on CodeBuild, there's this error on provisioning stage:

SINGLE_BUILD_CONTAINER_DEAD: Build container found dead before completing the build. Build container died because it was out of memory, or the Docker image is not supported

I assume this is because I'm using an M1 processor, would be really cool to add something like DockerBuildAssetOptions so we could choose the build platform

kichik commented 1 year ago

@sercantor yes it will. I should have something you can check out in a few days. It's almost ready.

But for now, maybe it can be a simple fix like https://github.com/CloudSnorkel/cdk-github-runners/pull/22 for CodeBuild. Can you try a similar change?

sercantor commented 1 year ago

I was able to deploy using a different computer 😄, I was going to contribute but seems like you're already working on it. Great work! 👍

kichik commented 1 year ago

@sercantor can you please take a look at #47? It should allow customization. It also builds the image in CodeBuild instead of locally. That means you won't need to use a different computer and cross-platform builds should be much easier.

sercantor commented 1 year ago

that is great progress! it's super useful to have all these options for a more granular approach, many thanks. 🙇‍♂️