feat: Option to register runners on organization instead of repo

[pharindoko]

App.svelte

• [x] Add ui component
• [x] Add parameter to new app request
• [x] Add parameter to existing app request

Secrets.ts

• [x] Create new secret for runner registration level in cdk

Setup.lambda.ts

• [x] Add secret arn to setup lambda.ts
• [x] Determine registration level based on permissions for newapp
• [x] Determine registration level for existing app
• [x] Update secret value

Tokenretriever.lambda.ts

• [x] Add env variable for registration level / secret arn
• [x] Add new condition to register token from org (octokit)

Determine runner registration config command for:

• [x] ec2 linux(userdata)
• [x] ec2 windows(userdata)
• [x] fargate linux
• [x] lambda linux
• [x] lambda linux arm
• [x] codebuild linux
• [x] codebuild linux arm
• [x] ecs linux
• [x] ecs linux arm
• [x] ec2 linux arm
• [x] ...

Tests:

• [x] create new app with org level registration
• [x] create with existing app with org level registration
• [x] run default integration test to setup solution
• [x] run github action runners with all providers in default integration test in github.com

result:

closes #442

[kichik]

Determine runner registration config command for:

This might be easier if we do #452 first.

[pharindoko]

Determine runner registration config command for:

This might be easier if we do #452 first.

Yes makes sense. I can continue to work on the your findings in the meantime.

[pharindoko]

I know it's still a draft, but I thought some early feedback might help.

That was the intention. Thanks for your feedback. Feel free to add changes directly. This PR affects way too much pieces that I can do it without your contribution.

[pharindoko]

@kichik

I`m ready :)

[kichik]

I am seeing issues with specifically Fargate failing to update the runner version and exiting. It doesn't feel related, but I have to confirm. Have you seen something like this?

  | 2023-10-26T21:40:18.885-04:00 | Current runner version: '2.310.2'
  | 2023-10-26T21:40:18.886-04:00 | 2023-10-27 01:40:18Z: Listening for Jobs
  | 2023-10-26T21:40:28.438-04:00 | Runner update in progress, do not shutdown runner.
  | 2023-10-26T21:40:28.551-04:00 | Downloading 2.311.0 runner
  | 2023-10-26T21:41:11.211-04:00 | Waiting for current job finish running.
  | 2023-10-26T21:41:11.262-04:00 | Generate and execute update script.
  | 2023-10-26T21:41:11.306-04:00 | Runner will exit shortly for update, should be back online within 10 seconds.
  | 2023-10-26T21:41:11.315-04:00 | Runner update process finished.
  | 2023-10-26T21:41:11.847-04:00 | Runner listener exit because of updating, re-launch runner after successful update
  | 2023-10-26T21:41:42.021-04:00 | Restarting runner...
  | 2023-10-26T21:41:42.058-04:00 | /home/runner/run-helper.sh: line 36: /home/runner/bin/Runner.Listener: No such file or directory
  | 2023-10-26T21:41:42.058-04:00 | Exiting with unknown error code: 127
  | 2023-10-26T21:41:42.058-04:00 | Exiting runner...

[pharindoko]

I am seeing issues with specifically Fargate failing to update the runner version and exiting. It doesn't feel related, but I have to confirm. Have you seen something like this?

  | 2023-10-26T21:40:18.885-04:00 | Current runner version: '2.310.2'

  | 2023-10-26T21:40:18.886-04:00 | 2023-10-27 01:40:18Z: Listening for Jobs

  | 2023-10-26T21:40:28.438-04:00 | Runner update in progress, do not shutdown runner.

  | 2023-10-26T21:40:28.551-04:00 | Downloading 2.311.0 runner

  | 2023-10-26T21:41:11.211-04:00 | Waiting for current job finish running.

  | 2023-10-26T21:41:11.262-04:00 | Generate and execute update script.

  | 2023-10-26T21:41:11.306-04:00 | Runner will exit shortly for update, should be back online within 10 seconds.

  | 2023-10-26T21:41:11.315-04:00 | Runner update process finished.

  | 2023-10-26T21:41:11.847-04:00 | Runner listener exit because of updating, re-launch runner after successful update

  | 2023-10-26T21:41:42.021-04:00 | Restarting runner...

  | 2023-10-26T21:41:42.058-04:00 | /home/runner/run-helper.sh: line 36: /home/runner/bin/Runner.Listener: No such file or directory

  | 2023-10-26T21:41:42.058-04:00 | Exiting with unknown error code: 127

  | 2023-10-26T21:41:42.058-04:00 | Exiting runner...

Hey @kichik,

no I haven't seen this message before. ... But I haven't triggered and tested an update of a fargate runner by intention.

Does the same issue occur on the main branch ?

[kichik]

@pharindoko I think I'm done with my adjustments. The only thing I still want to do is test the setup function to see that it can still create apps after my changes for both repo and org levels. Let me know if it looks good to you too.

[pharindoko]

@pharindoko I think I'm done with my adjustments. The only thing I still want to do is test the setup function to see that it can still create apps after my changes for both repo and org levels. Let me know if it looks good to you too.

Have seen your changes. I think it's fine.

Sorry that I missed to cleanup the runner level and check the formatting again.

The only thing I thought about is that it might be good to add some additional unit tests for the lambdas.

Will try to run the integration tests as well in my account when I have time - but don't wait for it...

[kichik]

We forgot to deal with runner deletion. I will have another pass tomorrow to see nothing else was missed.