Closed kichik closed 1 year ago
See the updated readme for usage.
Would it be more obvious to have a matching provider label for self-hosted.yml
and the readme? Like:
// create a custom CodeBuild provider
const myProvider = new CodeBuildRunner(this, 'codebuild runner', {
label: 'codebuild-x64',
...
});
// grant some permissions to the provider
...
// create the runner infrastructure
new GitHubRunners(this, 'runners', {
providers: [codebuild-x64],
});
I'm just suggesting it because there may be people copying from the readme and not seeing their workers running because the labels don't match when they run their workflow against self.hosted.yml
. Also makes it obvious for people to see that there are options for architecture.
Again, it's just a suggestion 🤷
That's a good point. I keep forgetting to add proper workflow example. self-hosted.yml
is not an ideal example. It's way too complex.
great commit, it's definitely more readable now, thanks for all the work 👍
Build images in AWS using CodeBuild (or any user configured method) so that:
BREAKING CHANGE: providers no longer take runner version directly