fix: Replace deprecated property for cleaning up ECR repositories

CloudSnorkel / cdk-github-runners

CDK constructs for self-hosted GitHub Actions runners

https://constructs.dev/packages/@cloudsnorkel/cdk-github-runners/

Apache License 2.0

255 stars 37 forks source link

fix: Replace deprecated property for cleaning up ECR repositories #538

Closed jonathanmorley closed 1 week ago

kichik commented 3 weeks ago

emptyOnDelete is awesome, but it requires CDK v2.116.0 while we still support v2.111.0.

https://github.com/CloudSnorkel/cdk-github-runners/blob/7a8faa644934b7b22794b5ec6cbdcb64077a85bc/.projenrc.js#L10

I will merge this once we upgrade.

kichik commented 2 weeks ago

Do you have an option to let me push to this branch? I am unable to update it with the latest snapshot. Alternatively, can you merge main, npm run integ:default:snapshot and push?