CloudSnorkel / cdk-github-runners

CDK constructs for self-hosted GitHub Actions runners
https://constructs.dev/packages/@cloudsnorkel/cdk-github-runners/
Apache License 2.0
258 stars 37 forks source link

missing tools on windows runner for github cache action #571

Closed pharindoko closed 1 month ago

pharindoko commented 1 month ago

Hey @kichik,

to support github actions cache on windows zstd and GNU tar have to be installed. https://github.com/actions/cache?tab=readme-ov-file#pre-requisites

I checked the runner images repo:

This is out of the box available on the windows github runners. https://github.com/actions/runner-images/blob/main/images/windows/scripts/build/Install-Zstd.ps1

for GNU tar 7zip is installed as basic tool: https://github.com/actions/runner-images/blob/80ea4b55c056a86a968ef7a02307a478fd105a46/images/windows/Windows2022-Readme.md#tools

can we install those as general tools in windows ?

kichik commented 1 month ago

tar is already there. Adding zstd sounds good to me.

pharindoko commented 3 weeks ago

Hey @kichik,

can you release it please :)

kichik commented 3 weeks ago

Sure. I was hoping to get the other Windows issue first.

pharindoko commented 3 weeks ago

thanks :)