search

CloudSoda / go-smb2

Client implementation of the SMB 2 & 3 protocols
BSD 2-Clause "Simplified" License
12 stars 5 forks source link

open to PRs? #10

Closed deitch closed 10 months ago

deitch commented 11 months ago

I have been using the lib this was based upon, but that hasn't been updated in well over a year, and issues and PRs are getting no attention.

I have just one PR for now, making initiator members public. Are you open to pulling that in? I would be happy to open that PR to here as well.

Thanks

arashpayan commented 11 months ago

Hi @deitch. Yes, I'm open to accepting PRs for new functionality, and making the Initiator methods public sounds good.

deitch commented 11 months ago

First one is open at #11

I have two follow-ups in mind:

Any objections?

arashpayan commented 11 months ago

Both of those sound good. :+1:

deitch commented 11 months ago

Great. You'll see them in the coming days.

deitch commented 11 months ago

12 for lint

arashpayan commented 10 months ago

Linting and anonymous auth are now both in main.