Golint

[deitch]

First commit adds golint action to the CI workflow. Second commit cleans up all of the lint errors.

• where it complained about ignored return values, explicitly added _ =. This includes in defer statements
• where it complained about unused structs, vars, or member functions, added a //nolint:unused, so we can track it.
• where it complained about ineffective assignment, added a //nolint:ineffassign, so we can track it.

In all cases, we endeavoured not to change the logic at all, including leaving unused vars or funcs, or ineffective assignment. Instead, we added //nolint comments, so we can track them and it passes CI.

Any of these always can be removed later, probably should, but in their own dedicated small PRs.

[arashpayan]

Thanks @deitch. Can you tell me why you exported the methods of spnegoClient? Was it just so it would be consistent with the Initiator interface or was there a bug left over from the Initiator interface changes in the previous MR?

[deitch]

It was partially for consistency, and partially because they weren't used anywhere, so the linter complained. The choices were remove them, add nolint comments, or export them. Since they matched the Initiator interface, that seemed the most logical route.

If there's a different approach, happy to change it.

[arashpayan]

That's a reasonable choice. Thanks for the clarification. 👍