Don't hard code username for allowing docker commands

CloudVE / ansible-docker-boot

Run any Docker container on any VM

0 stars 3 forks source link

Don't hard code username for allowing docker commands #1

Open afgane opened 5 years ago

afgane commented 5 years ago

The playbook hardcodes the username for the user that can use docker commands as it installs Docker on the host. Instead, this should probably be parameterized to be the same user as the ssh user.

Code: https://github.com/CloudVE/ansible-cloudman2/blob/84b527ae18273ace13ecf76fecf25c281d184e75/playbook.yml#L25

afgane commented 5 years ago

Relevant to this is the following deprecation warning around the same task:

[DEPRECATION WARNING]: evaluating docker_users as a bare variable, this
behaviour will go away and you might need to add |bool to the expression in the
 future. Also see CONDITIONAL_BARE_VARS configuration toggle.. This feature
will be removed in version 2.12.