search

Cloudbox / Community

Cloudbox Community Project
GNU General Public License v3.0
280 stars 132 forks source link

Add a "data" directory since transmissionvpn expects it #392

Closed tejassharma96 closed 2 years ago

tejassharma96 commented 2 years ago

Description

The transmissionvpn docker image assumes that you have mounted a volume to /data, and sets a lot of defaults based on that, such as the default download dir, incomplete downloads dir, and watch dir. Screen Shot 2022-02-21 at 5 14 27 PM When I installed transmissionvpn this data volume was not configured. This meant that docker generated the volume automatically and transmission used that dir rather than downloading to the created torrents folders.

I added a mount point pointing data (in the container) to {{ downloads.torrents }}/transmissionvpn (on the disk).

How Has This Been Tested?

Ran it locally and verified in portainer that it was being mounted correctly:
Screen Shot 2022-02-21 at 5 12 57 PM

I wasn't sure how to test it in the case that torrents_download_path doesn't exist and would appreciate any input you have on whether my code looks correct

chazlarson commented 2 years ago

I don't think you really need to account for the case where torrents_download_path doesn't exist since that's a pretty pathological case that would involve someone changing another role.

tejassharma96 commented 2 years ago

thanks!