search

Cloudbox / autoscan

Autoscan replaces the default Plex and Emby behaviour for picking up changes on the file system.
MIT License
597 stars 49 forks source link

Add Readarr Trigger #143

Closed rg9400 closed 1 year ago

rg9400 commented 2 years ago

First rough attempt at adding a Readarr trigger using Lidarr's trigger as a base. Additional events for Lidarr/Readarr pending until OnDelete is merged with both of them (Rename + OnDelete both pending)

m-rots commented 1 year ago

So I'm afraid that bridging all triggers to the new architecture is a breaking change.

A-Train accepts /a-train/{drive-id} routes. However, the -arr triggers essentially match at the root: /{name}. Funnily enough, you can thus call your Sonarr trigger radarr and everything would work just fine.

Bridging the triggers to the new architecture would force us to use /{trigger name}/{id} across the board. However, this would require users to update their -arr installs to point from /sonarr to e.g. /sonarr/sonarr.

But I'm not keen on the route having sonarr in there twice. Ideally, /sonarr would resolve to some default sonarr config option and users would write 4k as the name in their config instead of sonarr-4k, so the path would become /sonarr/4k.

We could write a migration script for this to get away with introducing a breaking change though.

m-rots commented 1 year ago

Closing in favour of #174. Thanks for the initial groundwork @rg9400 :)