Cloudbox / autoscan

Autoscan replaces the default Plex and Emby behaviour for picking up changes on the file system.
MIT License
611 stars 53 forks source link

Fatal error when target library is not found. #39

Closed Iguana9999phil closed 4 years ago

Iguana9999phil commented 4 years ago

I have 3 Plex servers and not all got the same libraries (1080p only, 1080p with 4k and 1080P with 4K and 4K Remux) Now when autoscan processes a remux it will have a fatal failure.

ERR Fatal error occurred while processing targets, processor stopped, triggers will continue... error="no target libraries found:

While I understand the thought behind it it would be better to (have the option) to not stop the processor and just continue with autoscan.

PS: This wasn't a problem with plex_autoscan, it would just gracefully skip it and continue so a regression in function in that regard.

m-rots commented 4 years ago

Right, this is a bit of an edge case in my opinion. The issue is marked as FATAL as 99% of users will only encounter this error when their rewrite rules are misconfigured or they have missing libraries. For this reason, I won't drop its fatal behaviour.

However, I'm not sure what the solution is either. The original PAS was not made with multiple Plex servers in mind and Autoscan assumes that your Plex servers have the same configuration when configuring multiple Plex targets.

I'm closing this issue for now as I think it's an edge case.

Iguana9999phil commented 4 years ago

Yes the original PAS didn't work with multiple Plex servers hence why I set it up the way I did. While an Edge case as 99% of users don't have more than 1 Plex server anyway an advance setting to override this default would already be fine for those 1% who do have strange edge cases.