search

CloudburstMC / Cloudburst

Cloudburst Server is a Bedrock first server software. Originally forked from Cloudburst Nukkit.
178 stars 70 forks source link

Changed World Generation to use random seed numbers if not specified #116

Closed TheShermanTanker closed 3 years ago

TheShermanTanker commented 3 years ago

Currently, Cloudburst uses the world name as the seed if it is not specified in the world config, requiring users to manually put a seed in every time a new world is loaded if they do not want to get the same world over and over again. This Pull Request cleans up some method names but most importantly adds the functionality of Vanilla-like random seed generation to replace the placeholder of using world names as seeds. (I'm not expecting this PR to be accepted, but rather to raise an issue in hopes that the Cloudburst maintainers might rectify this in the future, because this isn't a very complicated thing to implement but would be extremely frustrating for users if forgotten about when Cloudburst goes into production)

EDIT: If I may ask, what is planned for the default world loading? Does Cloudburst plan to have the default world options in Cloudburst yml? I was initially going to change the default and nether worlds to not depend on the yml file alongside the changes for seed generation but didn't do so in the end

TheShermanTanker commented 3 years ago

Above issues rectified

TheShermanTanker commented 3 years ago

Bump

EDIT: Nevermind my dumbass didn't realize github doesn't work this way

TheShermanTanker commented 3 years ago

@DaMatrix I've gotten back from checking the source and it does indeed seem that the seed stored inside level.dat is used if present- In fact, the seed inside level.dat will actually overwrite the seed from config and/or the randomly generated seed if the server can find it: https://github.com/CloudburstMC/Server/blob/b000e760aebf294af426c616a8a53853a4708add/src/main/java/org/cloudburstmc/server/level/provider/leveldb/serializer/LevelDBDataSerializer.java#L145

DaMatrix commented 3 years ago

alright, in that case i see no problems

TheShermanTanker commented 3 years ago

@SupremeMortal I felt like worlds was a better name than "levels", as it is slightly more descriptive, but I'll change it back if required

TheShermanTanker commented 3 years ago

Changed the names back, I do still prefer the ring "worlds" has as opposed to "levels" though, I changed them because the config class is named World and the variable is worldConfigs, and I was confused why they're called 2 different things

TheShermanTanker commented 3 years ago

Hi, just to check will the conflicts be automatically resolved on merge?

TheShermanTanker commented 3 years ago

Computer crashed and took the entire repo with it, starting new commit :/