search

CloudburstMC / Cloudburst

Cloudburst Server is a Bedrock first server software. Originally forked from Cloudburst Nukkit.
175 stars 70 forks source link

[2.0] Knockback calculation and entity damaging generally is broken #14

Open KCodeYT opened 4 years ago

KCodeYT commented 4 years ago

Entity knockback: Player1 hits Player2 and Player2 is getting knockback in the same direction everytime even the Player1 isnt looking in the direction.

Entity Damaging: You cant damage entitys (not players) if you are standing 2 blocks or more away from them

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/92042031-2-0-knockback-calculation-and-entity-damaging-generally-is-broken?utm_campaign=plugin&utm_content=tracker%2F182923979&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F182923979&utm_medium=issues&utm_source=github).
joserobjr commented 4 years ago

Additionally, you might get invulnerable to all damages when you are standing on a slime block, i think the if slime check should be inside the if damage cause is fall, I was going to test it yesterday but I ran out of time.

https://github.com/NukkitX/Nukkit/blob/abd10c1c7ce8a4cbdb5e0c6bef0813f7248956e0/src/main/java/cn/nukkit/player/Player.java#L3631-L3639

joserobjr commented 4 years ago

Entity Damaging: You cant damage entitys (not players) if you are standing 2 blocks or more away from them

I think I found the issue: image (That was only a spare click, I guess attackTime isn't updating due to the entity not ticking)