search

CloudburstMC / Nukkit

Cloudburst Nukkit - Nuclear-Powered Minecraft: Bedrock Edition Server Software
https://cloudburstmc.org
GNU General Public License v3.0
1.21k stars 420 forks source link

[1.16] Custom Skin Issue #1519

Open ghost opened 4 years ago

ghost commented 4 years ago

Expected Behavior

Your skin is visible to other players.

Actual Behavior

You see your skin but other players see a Steve skin.

Steps to Reproduce

  1. Join your server with your custom skin (I mean a skin loaded from a .png or a .jpg)
  2. Log your alt in and see that your other account's skin is a steve skin.

Debug information

None

Crashdump, Backtrace or Other Files

None

Checklist:

Sleepybear commented 4 years ago

Does this occur if you disable Allow only Trusted Skins in the client options under Profile tab?

ghost commented 4 years ago

Let me check

ghost commented 4 years ago

Nope, Issue still occurs.

Sleepybear commented 4 years ago

Does this still happen with 1.16.1 client? They referenced a fix to custom skins in the changelog

GamakCZ commented 4 years ago

Mojang displays only trusted skins (skins from marketplace).

Creeperface01 commented 4 years ago

@GamakCZ I don't think so since other servers are still using custom skins for NPCs

GamakCZ commented 4 years ago

Yep, you can set skin trusted even if the skin isn't from marketplace

https://github.com/NukkitX/Nukkit/blob/master/src/main/java/cn/nukkit/network/protocol/PlayerListPacket.java#L48 https://github.com/NukkitX/Nukkit/blob/master/src/main/java/cn/nukkit/network/protocol/PlayerSkinPacket.java#L28