search

CloudburstMC / Protocol

A protocol library for Minecraft Bedrock Edition
https://git.io/ProtocolLib
Apache License 2.0
312 stars 95 forks source link

Comments regarding BossEventPacket are outdated #173

Open inxomnyaa opened 1 year ago

inxomnyaa commented 1 year ago

https://github.com/CloudburstMC/Protocol/blob/0358afc119973a34af9c1d74e7cf6f58d1d7bcb5/bedrock/bedrock-common/src/main/java/com/nukkitx/protocol/bedrock/packet/BossEventPacket.java#L47-L61 Over the time (especially with 1.18) some of those fields have been implemented. The gophertunnel docs are partially updated: https://github.com/Sandertv/gophertunnel/blob/0de533a5e490f127330818ffba2c96b93b813e69/minecraft/protocol/packet/boss_event.go#L42-L59 I can confirm that the title and health percentage properties are working if the BossEntityUniqueID equals the player's UUID, i have not been able to test if they work with an actual entity yet though.

SupremeMortal commented 1 year ago

Will look into updating the docs for 3.0.0