Closed AJ-Ferguson closed 4 years ago
Implement
toString
,equals
, andhashCode
in theStackRequestActionData
classes.
Lombok can do that for you: https://projectlombok.org/features/ToString https://projectlombok.org/features/EqualsAndHashCode
Ready for review.
Notes:
Container.CREATIVE_OUTPUT
as the source when transferring output into the inventory. Maybe it should be renamed?StackRequestActionData
s where it would make sense to implement a common interface.Container
was the best name for the new enum as there is already a ContainerId
class. Maybe NetContainer
WIP PR to finish implementing inventory related packets for 1.16.
To-do:
SwapStackRequestActionData
. Wrong fields.ItemStackResponseSerializer
. Packet data ends ifsuccess
isfalse
.InventoryContentPacket
. The current implementation is wrong and shouldn't be using a map. #55toString
,equals
, andhashCode
in theStackRequestActionData
classes.ItemStackResponsePacket
andItemStackRequestPacket
CreativeContentPacket
to use the net id stored inItemData
instead of a map key.