search

Cloudef / bemenu

Dynamic menu library and client program inspired by dmenu
GNU General Public License v3.0
1.22k stars 94 forks source link

Add fixed height option(Addresses #270) #326

Closed merrittlj closed 1 year ago

merrittlj commented 1 year ago

Add a option to make the menu have a fixed height while in vertical mode using --fixed-height. This prevents the menu from shrinking or expanding while filtering through items.

I modified how the filtered item count is set for the counter(getting the filtered item count directly rather than relying on menu->filtered.count) for the sake of efficiency, and it fixed a bug with the counter in vertical mode.

Closes #270

merrittlj commented 1 year ago

@Cloudef Any update on this?

merrittlj commented 1 year ago

Should be ready to merge.

merrittlj commented 1 year ago

@Cloudef Any update on this? It's ready, and I've seen discussion about this feature on other issues.

aarobc commented 1 year ago

Please merge, this would be great to have.

Cloudef commented 1 year ago

Merged thanks!

adastx commented 1 year ago

--fixed-height option is only listed in the --help output, seem to be missing from the manpage.

merrittlj commented 1 year ago

I completely missed that. You can create a PR about it if you want, as I may not fix this anytime soon.

adastx commented 1 year ago

Created it :) #344.