search

Cloudef / bemenu

Dynamic menu library and client program inspired by dmenu
GNU General Public License v3.0
1.16k stars 90 forks source link

Split configuration variables to a `config.h` file. (suckless style) #373

Open MouadCharradi opened 7 months ago

MouadCharradi commented 7 months ago

This would allow for a separation between the configuration part and the logic part of bemenu.

Thanks

MouadCharradi commented 7 months ago

I just start reading the bemenu codebase, maybe there are more configuration variables that I haven't seen yet. Maybe we could put those in the config file as well.

Cloudef commented 7 months ago

Mostly the defaults in common.c perhaps (for bemenu and bemenu-run executable)

MouadCharradi commented 7 months ago

I have move more values to config.h from bemenu.c and bemenu-run.c. I'm not sure if there are any default variables that are set in common, it seems to me that it just handles cli opts and changes behavior accordingly, but I might be wrong.

As for the warnings, I will try to find a way of getting rid of them (maybe through a flto option in the Makefile). Let me know if I did anything wrong, or if there is anything else I should change or do, or even abandon this whole idea if it doesn't align with the project's vision.

Thanks. Mouad.